Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

TINY-10394: Made logs argument optional for VersionLoader.setup #75

Merged
merged 5 commits into from
Nov 28, 2023
Merged

TINY-10394: Made logs argument optional for VersionLoader.setup #75

merged 5 commits into from
Nov 28, 2023

Conversation

spocke
Copy link
Member

@spocke spocke commented Nov 24, 2023 •
edited
Loading

Related Ticket: TINY-10394

Description of Changes:

  • Made one argument optional with a default so that we can quickly port everything to miniature for the monorepo see the ticket for details.
  • Added a new VersionLoader.pLoadVersion function that comes in handy for tests that init the editor using McEditor
  • Bumped dependencies to reduced multiple versions of sugar etc.

Pre-checks:

  • Changelog entry added
  • package.json version bumped (if first change of new major/minor)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@spocke spocke requested a review from a team as a code owner November 24, 2023 12:13
@spocke spocke requested review from TheSpyder, hamza0867, ltrouton, a team, lostkeys, vpyshnenko and HAFRMO and removed request for a team November 24, 2023 12:13
ltrouton
ltrouton reviewed Nov 26, 2023
View reviewed changes
Copy link
Contributor

@ltrouton ltrouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be a major release of miniature since this PR removes sWithVersion from the API?

@ltrouton ltrouton self-requested a review November 26, 2023 20:40
@spocke
Copy link
Member Author

spocke commented Nov 27, 2023

Will this be a major release of miniature since this PR removes sWithVersion from the API?

Thanks for noticing that function was not supposed to be removed must have pushed the wrong button by accident. I guess we have not test for that API surface. But since we are moving away from step based tests I don't think it's worth adding a test for that function.

@spocke spocke merged commit 0960778 into main Nov 28, 2023
5 checks passed
@spocke spocke deleted the feature/TINY-10394 branch November 28, 2023 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HAFRMO HAFRMO HAFRMO approved these changes

@ltrouton ltrouton ltrouton approved these changes

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 is a code owner automatically assigned from tinymce/tinymce-reviewers

@lostkeys lostkeys Awaiting requested review from lostkeys lostkeys was automatically assigned from tinymce/high-velocity

@vpyshnenko vpyshnenko Awaiting requested review from vpyshnenko vpyshnenko was automatically assigned from tinymce/high-velocity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spocke @ltrouton @HAFRMO